Skip to content

Conversation

@ebyhr
Copy link
Contributor

@ebyhr ebyhr commented Aug 8, 2024

Description

Add integration test for Trino

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

Please delete options that are not relevant.

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • If adding new functionality, I have discussed my implementation with the community using the linked GitHub issue
  • I have signed and submitted the ICLA and if needed, the CCLA. See Contributing for details.

@ebyhr ebyhr requested a review from a team as a code owner August 8, 2024 12:37
@ebyhr ebyhr marked this pull request as draft August 8, 2024 12:46
@flyrain
Copy link
Contributor

flyrain commented Aug 8, 2024

Build failed. I just realized it is in draft state. Could you make it ready for review before asking a review? Thanks a lot.

@github-actions
Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Sep 11, 2024
@github-actions github-actions bot closed this Sep 16, 2024
snazy added a commit to snazy/polaris that referenced this pull request Nov 20, 2025
* Always propagate non-credential properties from AccessConfig to clients (apache#2615)

* Always propagate non-credential properties from AccessConfig to clients

This change builds on top of apache#2589 and further prepares Polaris code to
support non-STS S3 implementations for apache#2589.

For S3 implementations that do have STS, this change enables clients to
run with local credentials (no credential vending) and still receive
endpoint configuration from the catalog.

* Call `SupportsCredentialDelegation.getAccessConfig()` on all relevant
  create/load requests (previously it was called only when
  `vended-credentials` was requested

* Always sent `AccessConfig.extraProperties()` to clients

* Expose credentials to clients only when the `vended-credentials` access
  delegation mode is requested.

* There is not client-visible behaviour change for implementations of
  `PolarisStorageIntegration` that do not produce "extra" `AccessConfig`
  properties.

* [OpenAPI Modification] Return created objects (apache#2603)

As per the ML thread [here](https://lists.apache.org/thread/q7q0rrsmw5gcqv30g4hr9ffq3gtr72yk), this PR introduces the change to return all objects that are created within their respective API calls.

* chore(docs): reorganize getting-started section (apache#2611)

* fix(deps): update dependency org.assertj:assertj-core to v3.27.6 (apache#2651)

* fix: fix broken markdown-link-check CI job after apache#2611 got merged (apache#2655)

* Release artifacts should use dlcdn.apache.org (signature and checksum must refer downloads.apache.org) (apache#2647)

* docs: Update S3 getting started guides (apache#2652)

* fix(deps): update dependency com.google.cloud:google-cloud-storage-bom to v2.58.0 (apache#2660)

* fix(deps): update dependency org.apache.spark:spark-sql_2.12 to v3.5.7 (apache#2659)

* fix(deps): update dependency org.apache.spark:spark-sql_2.12 to v3.5.7 (apache#2658)

* Fix Issue 2024 for Rendering Blockquotes (apache#2656)

* Fix Issue 2024 for Rendering Blockquotes

* Small fix for URLs

* Update license

* Last merged commit fcb6b33

---------

Co-authored-by: Dmitri Bourlatchkov <dmitri.bourlatchkov@gmail.com>
Co-authored-by: Adnan Hemani <adnan.h@berkeley.edu>
Co-authored-by: Artur Rakhmatulin <artur.rakhmatulin@gmail.com>
Co-authored-by: Mend Renovate <bot@renovateapp.com>
Co-authored-by: JB Onofré <jbonofre@apache.org>
Co-authored-by: Adam Christian <105929021+adam-christian-software@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants