Skip to content

Mark final fields as such #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snazy merged 1 commit into from
Aug 23, 2024
Merged

Mark final fields as such #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion polaris-service/src/test/java/io/polaris/service/PolarisApplicationIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ public class PolarisApplicationIntegrationTest {
LoggerFactory.getLogger(PolarisApplicationIntegrationTest.class);

public static final String PRINCIPAL_ROLE_NAME = "admin";
private static DropwizardAppExtension<PolarisApplicationConfig> EXT =
private static final DropwizardAppExtension<PolarisApplicationConfig> EXT =
new DropwizardAppExtension<>(
PolarisApplication.class,
ResourceHelpers.resourceFilePath("polaris-server-integrationtest.yml"),
Expand Down
2 changes: 1 addition & 1 deletion ...s-service/src/test/java/io/polaris/service/catalog/PolarisRestCatalogIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ public class PolarisRestCatalogIntegrationTest extends CatalogTests<RESTCatalog>
private static final String S3_BUCKET_BASE =
Optional.ofNullable(System.getenv("INTEGRATION_TEST_S3_PATH"))
.orElse("file:///tmp/buckets/my-bucket");
private static DropwizardAppExtension<PolarisApplicationConfig> EXT =
private static final DropwizardAppExtension<PolarisApplicationConfig> EXT =
new DropwizardAppExtension<>(
PolarisApplication.class,
ResourceHelpers.resourceFilePath("polaris-server-integrationtest.yml"),
Expand Down
2 changes: 1 addition & 1 deletion ...rvice/src/test/java/io/polaris/service/catalog/PolarisRestCatalogViewIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ public class PolarisRestCatalogViewIntegrationTest extends ViewCatalogTests<REST
public static final String S3_BUCKET_BASE =
Optional.ofNullable(System.getenv("INTEGRATION_TEST_S3_PATH"))
.orElse("file:///tmp/buckets/my-bucket");
private static DropwizardAppExtension<PolarisApplicationConfig> EXT =
private static final DropwizardAppExtension<PolarisApplicationConfig> EXT =
new DropwizardAppExtension<>(
PolarisApplication.class,
ResourceHelpers.resourceFilePath("polaris-server-integrationtest.yml"),
Expand Down
2 changes: 1 addition & 1 deletion polaris-service/src/test/java/io/polaris/service/catalog/PolarisSparkIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public class PolarisSparkIntegrationTest {

public static final String CATALOG_NAME = "mycatalog";
public static final String EXTERNAL_CATALOG_NAME = "external_catalog";
private static S3MockContainer s3Container =
private static final S3MockContainer s3Container =
new S3MockContainer("3.9.1").withInitialBuckets("my-bucket,my-old-bucket");
private static PolarisConnectionExtension.PolarisToken polarisToken;
private static SparkSession spark;
Expand Down
10 changes: 5 additions & 5 deletions polaris-service/src/test/java/io/polaris/service/task/TestSnapshot.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,11 @@
import org.apache.iceberg.io.FileIO;

final class TestSnapshot implements Snapshot {
private long sequenceNumber;
private long snapshotId;
private long parentSnapshot;
private long timestampMillis;
private String manifestListLocation;
private final long sequenceNumber;
private final long snapshotId;
private final long parentSnapshot;
private final long timestampMillis;
private final String manifestListLocation;

public TestSnapshot(
long sequenceNumber,
Expand Down