Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pull_request_template.md to use absolute links #17

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Update pull_request_template.md to use absolute links #17

merged 1 commit into from
Jul 30, 2024

Conversation

ajantha-bhat
Copy link
Member

Relative links doesn't work while raising the PR as it will be from github pull request page. So, need to use the absolute links.

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

Please delete options that are not relevant.

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • If adding new functionality, I have discussed my implementation with the community using the linked GitHub issue
  • I have signed and submitted the ICLA and if needed, the CCLA. See Contributing for details.

@ajantha-bhat
Update pull_request_template.md to use absolute links
9b5e2e1 
Relative links doesn't work while raising the PR as it will be from github pull request page. So, need to use the absolute links.
@jbonofre jbonofre enabled auto-merge (squash) July 30, 2024 17:51
@jbonofre jbonofre merged commit ee44b99 into apache:main Jul 30, 2024
3 checks passed
eric-maynard pushed a commit to eric-maynard/polaris that referenced this pull request Jul 30, 2024
@sfc-gh-dhuo
Re-add explicit Java handling if we detect os is linux. (apache#17)
8775ff1
eric-maynard pushed a commit to eric-maynard/polaris that referenced this pull request Jul 30, 2024
@sfc-gh-emaynard
SNOW-1551596: Add quickstart documentation (apache#17)
1a83b9a 
<!-- Please describe your change here and remove this comment -->

This PR introduces quickstart documentation and adds a basic structure
for OSS docs.

## Pre-review checklist
- [ ] I attest that this change meets the bar for low risk without
security requirements as defined in the [Accelerated Risk Assessment
Criteria](https://developer-handbook.m1.us-west-2.aws.app.snowflake.com/docs/reference/security-review/accelerated-risk-assessment/#eligibility)
and I have taken the [Risk Assessment Training in
Workday](https://wd5.myworkday.com/snowflake/learning/course/6c613806284a1001f111fedf3e4e0000).
- Checking this checkbox is mandatory if using the [Accelerated Risk
Assessment](https://developer-handbook.m1.us-west-2.aws.app.snowflake.com/docs/reference/security-review/accelerated-risk-assessment/)
to risk assess the changes in this Pull Request.
- If this change does not meet the bar for low risk without security
requirements (as confirmed by the peer reviewers of this pull request)
then a [formal Risk
Assessment](https://developer-handbook.m1.us-west-2.aws.app.snowflake.com/docs/reference/security-review/risk-assessment/)
must be completed. Please note that a formal Risk Assessment will
require you to spend extra time performing a security review for this
change. Please account for this extra time earlier rather than later to
avoid unnecessary delays in the release process.
- [ ] This change has code coverage for the new code added
eric-maynard pushed a commit to eric-maynard/polaris that referenced this pull request Jul 30, 2024
@sfc-gh-mcollado
Squashed 'polaris/' changes from e8e08d6..85e69a3
3e6e01a 
85e69a3 Add ascii art banner after initialization. (apache#45)
398a264 Add issue + PR templates (apache#27)
2607c97 Retain original copyright in `gradlew` (apache#43)
bb8dcf5 Simplify spotless-java expression (apache#24)
6f5bda0 Gradle wrapper - download and verify (apache#32)
7640ec8 No copyright in PR template (apache#33)
b939de0 Upgrade to Gradle 8.9 (apache#29)
32b9520 Upgrade to Jackson 2.17.2 (apache#30)
875b8fc Set project name in IDE (apache#23)
fa430e8 Prominently warn for Java version < 21 (apache#22)
a9c1807 Add Apache license header (apache#19)
bfc111d Add some more exclusions to `.gitignore` (apache#20)
d9abad8 Suppress unchecked cast warning in DefaultConfigurationStore (apache#18)
7cae6f4 Add base skeleton with updated LICENSE and NOTICE file (apache#8)
4988075 Fix typo in the quickstart docs. (apache#17)
1c4455f Bump gradle/actions from 3.4.2 to 3.5.0 (apache#14)
76fd0f4 Merge Polaris catalog code (#1)
REVERT: e8e08d6 Merge remote-tracking branch 'managed-polaris-local/polaris-oss-export' into mcollado-polaris-merge
REVERT: 842b08d Made regtest resources configurable
REVERT: cad1390 Merge branch 'managed-polaris' into mcollado-polaris-import
REVERT: 136f67b SNOW-1543690 Make credentialRotationRequired optional when creating a principal (apache#5)
REVERT: 1552b35 Reorganized repository and split Snowflake and OSS Polaris projects with distinct builds (apache#268)
REVERT: 3063229 Add brief description to README
REVERT: bcc8f65 Initial commit
REVERT: 6fa40a9 Merge branch 'main' of github.com:snowflakedb/pinnacle into dhuo-merge-pinnacle-main
REVERT: 747cf3e SNOW-1528940 Fix usability issues related to the pentest of invalid role ARN (apache#279)
REVERT: 0325090 Merge remote-tracking branch 'pinnacle/main' into mcollado-merge-pinnacle
REVERT: 01ffd22 Remove the "required" annotation for remoteUrl in ExternalCatalog. (apache#280)
REVERT: 6a3de99 Merge remote-tracking branch 'pinnacle/main'
REVERT: 1bbd9b1 Minor fixups to preserve semantics of some of the helper scripts after the restructure. (apache#278)
REVERT: 2186b72 Adding bootstrap action for self hosted Polaris (apache#277)
REVERT: 8f9639d Update model validation to use jakarta.validation annotations (apache#276)
REVERT: a80ba68 Update repository references to managed-polaris
REVERT: 6736d60 Improve error message for invalid json and distinguish from invalid values (apache#274)
REVERT: 92bb3a4 Extended gradle format in root project to apply to oss (apache#273)
REVERT: a3f049c Fix json error messages to return clearer validation causes (apache#272)
REVERT: a4aecf4 Reorganized repository and split Snowflake and OSS Polaris projects with distinct builds (apache#268)

git-subtree-dir: polaris
git-subtree-split: 85e69a3007fb89c0aeff7b9aec348538abad3dd1
kevinjqliu pushed a commit to kevinjqliu/polaris-catalog that referenced this pull request Jul 31, 2024
@anoopj @collado-mike @sfc-gh-mcollado
Fix typo in the quickstart docs. (apache#17)
e1339e5 
Co-authored-by: Michael Collado <40346148+collado-mike@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbonofre jbonofre jbonofre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajantha-bhat @jbonofre