-
Notifications
You must be signed in to change notification settings - Fork 338
Add muti-platform Docker images staging in the release guide #2039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the machine's requirements for "buildx"? Docker? Podman?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docker (we use
quarkus-container-image-dockerdependency by default).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, not sure Docker's a great implied requirement due to the licensing implications that it brings for most devs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Podman also supports multi-platform images "natively" (without
buildx). If we want to use podman, we should update the dependency here: https://github.com/apache/polaris/blob/main/runtime/server/build.gradle.kts#L55 (to use podman instead of docker).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, last time I tried multi-arch builds with podman, the resulting manifests were corrupted. But, maybe it's fixed/improved now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect, it's not an issue (license wise) to use Docker buildx in ASF GH workflows. Just for potentially for devs locally.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. podman can do multi-arch build without buildx now a day (I used it at work as well). Due to the above concern with licensing around docker, does it makes sense to deprecate docker and promo podman instead? Also, for buildx on docker with Mac/Windows, additional steps are needed on the build machines other than the additional parameters specify above.
One more catch with podman is it will add container registry info (by default
docker.io) to the image name. When building with docker, we will getapache/polaris:xxxx. However, if we build with podman, it will then becomedocker.io/apache/polaris:xxxx. In case if we want to promo podman as oppose to docker, we shoild container add additional parameter to set registry info as part of the image build (so both docke/podman will produce same images name) then update our docs accordingly.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I propose to move forward with Docker for now, we can switch to podman in another PR. Thoughts ?