Rework getOrCreateSessionSupplier #2161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adutra
previously approved these changes
Jul 23, 2025
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
dimas-b
previously approved these changes
Jul 23, 2025
Contributor
There was a problem hiding this comment.
nit: previously the .get() call was outside the synchronized block... not sure it matters, though 🤔
Contributor
|
@XN137 : Changes LGTM. Please resolve conflicts :) |
note how all the caller immediately called `get` on the returned `Supplier`. it seems like the `Supplier` was an leaking implementation detail of the `MetaStoreManagerFactor` implementations.
XN137
force-pushed
the
rework-getOrCreateSessionSupplier
branch
from
18ab8cc to
b58e293
Compare
Contributor
Author
|
rebased after tiny conflicts with 5faa371 |
dimas-b
approved these changes
Jul 23, 2025
adutra
approved these changes
Jul 24, 2025
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
snazy
added a commit
to snazy/polaris
that referenced
this pull request
Nov 20, 2025
* Extract ResolverFactory from PolarisEntityManager (apache#2148) `PolarisEntityManager.prepareResolver` was the only place that used the `EntityCache`. By introducing an application-scoped `ResolverFactory` the creation of an `EntityCache` is decided only once in `QuarkusProducers`, which will become the only place where `MetaStoreManagerFactory.getOrCreateEntityCache` gets called. Note that the little left-over functionality of `PolarisEntityManager` can be split out to more dedicated interfaces in a follow-up most likely. * Run standard (sharable) REST Catalog integrations tests with MinIO (apache#2158) * Run standard (sharable) REST Catalog integrations tests with MinIO Keep special edge case tests (path style, STS endpoint and client-side FileIO) in `QuarkusRestCatalogMinIoSpecialIT`. * fix(deps): update quarkus platform and group (apache#2166) * fix(deps): update dependency io.smallrye.config:smallrye-config-core to v3.13.4 (apache#2165) * Simplify checkPolarisServiceBootstrappedForRealm (apache#2162) * fix(deps): update dependency boto3 to v1.39.12 (apache#2169) * Improve Realm ID resolution for Quarkus 3.24+ (apache#2163) In Quarkus 3.24, it is now possible to retrieve context locals inside HttpServerMetricsTagsContributor. This greatly simplifies our RealmIdTagContributor implementation. It is also now possible to return null from ValueExpressionResolver. This is not a big deal, but still better than returning "". * chore(deps): update plugin jandex to v2.2.0 (apache#2175) * Add muti-platform Docker images staging in the release guide (apache#2039) * fix(deps): update dependency org.apache.commons:commons-text to v1.14.0 (apache#2178) * Rework getOrCreateSessionSupplier (apache#2161) note how all the caller immediately called `get` on the returned `Supplier`. it seems like the `Supplier` was an leaking implementation detail of the `MetaStoreManagerFactor` implementations. * Respond with 409 in case of concurrent Namespace update failures instead of 500 (apache#1989) * NoSQL adoptions * Last merged commit e9267b6 --------- Co-authored-by: Christopher Lambert <xn137@gmx.de> Co-authored-by: Dmitri Bourlatchkov <dmitri.bourlatchkov@gmail.com> Co-authored-by: Mend Renovate <bot@renovateapp.com> Co-authored-by: Alexandre Dutra <adutra@apache.org> Co-authored-by: JB Onofré <jbonofre@apache.org> Co-authored-by: fabio-rizzo-01 <fabio.rizzocascio@jpmorgan.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note how all the callers immediately called
Supplier.get- it seems like theSupplierhas become a leaking implementation detail of theMetaStoreManagerFactoryclasses.