Replace TestPolarisMetaStoreManager with Mockito.spy #2230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this takes less code and is more flexible in the future
XN137
commented
Aug 1, 2025
| * faults. Currently, you can force loadEntity() to return ENTITY_NOT_FOUND for a set of entity | ||
| * IDs. | ||
| */ | ||
| public static class TestPolarisMetaStoreManager extends TransactionalMetaStoreManagerImpl { |
Contributor
Author
There was a problem hiding this comment.
in terms of test coverage, does it matter that instead of TransactionalMetaStoreManagerImpl we are now using the one from TestServices (which seem to be TreeMapTransactionalPersistenceImpl) ? 🤔
adutra
approved these changes
Aug 1, 2025
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
dimas-b
approved these changes
Aug 1, 2025
snazy
approved these changes
Aug 4, 2025
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
snazy
added a commit
to snazy/polaris
that referenced
this pull request
Nov 20, 2025
* feat: Add `endpointInternal` to `AwsStorageConfigInfo` (apache#2213) * feat: Add `endpointInternal` to `AwsStorageConfigInfo` This API change is backward compatible with older clients and server using old storage configuration. * The `endpointInternal` allows Polaris Servers to use a different host name (or IP address) for accessing S3 storage than clients. This is not a common use case, but may be relevant is more complex environments. * If not set `endpointInternal` defaults to `endpoint`. * The STS endpoint default changes to `endpointInternal`. Contributes to apache#1530 * Fix deprecated Quarkus log properties (apache#2216) see https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.19#other-changes-gear-white_check_mark CI Quarkus tests were logging this repeatedly: ``` The "quarkus.log.file.json" config property is deprecated and should not be used anymore. The "quarkus.log.console.json" config property is deprecated and should not be used anymore. The "quarkus.log.file.json" config property is deprecated and should not be used anymore. The "quarkus.log.console.json" config property is deprecated and should not be used anymore. ``` * chore(deps): update dependency mypy to >=1.17, <=1.17.1 (apache#2218) * fix(deps): update dependency boto3 to v1.40.1 (apache#2240) * fix(deps): update dependency com.azure:azure-sdk-bom to v1.2.37 (apache#2242) * JDBC: Log SQL statements at debug level (apache#2221) * Add ResolutionManifestFactory (apache#2210) after 95358a9 very little functionality was left in `PolarisEntityManager`. by splitting out the more dedicated `ResolutionManifestFactory` we can remove `PolarisEntityManager` and `RealmEntityManagerFactory` completely it seems. * Prepare upgrade to Gradle 9 (apache#2237) * `shadowPub.kt` the change removes a special case that doesn't apply to Polaris * `api/...` build scripts - changes due to nullable type handling (`Property<String>` vs `Property<String?>` - latter is ... weird) * fix(deps): update dependency software.amazon.awssdk:bom to v2.32.14 (apache#2246) * Replace TestPolarisMetaStoreManager with Mockito.spy (apache#2230) this takes less code and is more flexible in the future * Remove obsolete information from README-quarkus.md (apache#2252) * fix(deps): update dependency boto3 to v1.40.2 (apache#2256) * fix(deps): update dependency com.gradleup.shadow:shadow-gradle-plugin to v8.3.9 (apache#2260) * fix(deps): update immutables to v2.11.2 (apache#2257) * Only pass `RealmConfig` to `PolarisStorageIntegration` (apache#2234) All `PolarisStorageIntegration` requite only the `RealmConfig`, not the whole `CallContext`. This makes it easier for the new tasks impleemntations (both proposals). * QuarkusProducers: remove unneeded `BasePersistence` producer (apache#2255) * Use application-scope clock when generating GCP credentials (apache#2241) This change also fixes a flaky test: `StorageConfigurationTest.testCreateGcpCredentialsFromStaticToken` * chore(deps): update plugin jetbrains-changelog to v2.4.0 (apache#2264) * chore(deps): update gradle/actions digest to 017a9ef (apache#2265) * Remove config parameter from `PolarisStorageIntegration#getSubscopedCreds` (apache#2235) Instances of `PolarisStorageIntegration` are created for a particular `PolarisStorageConfigurationInfo`, the same value is then passed into `PSI.getSubscopedCreds()`. This change removes the config parameter, as it's already known when `PolarisStorageIntegration` instances are created. * chore(deps): update registry.access.redhat.com/ubi9/openjdk-21-runtime docker tag to v1.22-1.1753981256 (apache#2266) * Make `*StorageConfigurationInfo` types immutable (apache#2236) This change eventually enables usage of the `*StorageConfigurationInfo` in the `StorageCredentialCacheKey` due to the then memoized hash-code values, to eliminate a couple of JSON re-serializations. * JDBC: SERIALIZABLE/EntityNotFoundException (apache#2219) With serializable isolation level, if either the primary-key or the check-constraint are violated, the lookup of the conflicting entity is not guaranteed to yield a non-null result (transaction start matters). This changes works around this situation w/ serializable isolation. * Merge polaris-service-common into polaris-runtime-service (apache#2233) * JdbcMetaStoreManagerFactory determines schemaVersion once per realm (apache#2217) otherwise every call to `MetaStoreManagerFactory.getOrCreateSession` was running the query. * Last merged commit af69d9f --------- Co-authored-by: Dmitri Bourlatchkov <dmitri.bourlatchkov@gmail.com> Co-authored-by: Christopher Lambert <xn137@gmx.de> Co-authored-by: Mend Renovate <bot@renovateapp.com> Co-authored-by: Alexandre Dutra <adutra@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this takes less code and is more flexible in the future