Remove PolarisCallContext from BasePersistence et al
#2254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
snazy
force-pushed
the
basepersistence-remove-pcc
branch
from
bcc4c82 to
4b6041e
Compare
Following up on apache#2251, this change removes the `PolarisCallContext` parameter from the interfaces `BasePersistence`, `IntegrationPersistence` and `PolicyMappingPersistence`. None of the implementations used the parameter for anything else than getting a `PolarisDiagnostics` instance, which is implicitly available in the containing type.
snazy
force-pushed
the
basepersistence-remove-pcc
branch
from
4b6041e to
61913d4
Compare
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #2251, this change removes the
PolarisCallContextparameter from the interfacesBasePersistence,IntegrationPersistenceandPolicyMappingPersistence. None of the implementations used the parameter for anything else than getting aPolarisDiagnosticsinstance, which is implicitly available in the containing type.