Add subtype-check to PolarisEntity subclass ctors #2492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XN137
force-pushed
the
entity-sub-type-check
branch
3 times, most recently
from
76c4f94 to
1d60ff8
Compare
XN137
commented
Sep 3, 2025
| tableIdentifier, PolarisEntityType.TABLE_LIKE, PolarisEntitySubType.ANY_SUBTYPE); | ||
| GenericTableEntity entity = | ||
| GenericTableEntity.of( | ||
| resolvedEntities == null ? null : resolvedEntities.getRawLeafEntity()); |
Contributor
Author
There was a problem hiding this comment.
not every table-like entity we find here is a generic table
XN137
commented
Sep 3, 2025
| .getBaseLocation(); | ||
| PolarisEntity tableEntity = resolveTablePath.getRawLeafEntity(); | ||
| if (tableEntity.getSubType() == PolarisEntitySubType.GENERIC_TABLE) { | ||
| return GenericTableEntity.of(tableEntity).getBaseLocation(); |
Contributor
Author
There was a problem hiding this comment.
since the getBaseLocation() impl is different between GenericTableEntity and IcebergTableLikeEntity this might have actually fixed a bug?
adutra
approved these changes
Sep 3, 2025
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java
Show resolved
Hide resolved
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
dimas-b
approved these changes
Sep 3, 2025
XN137
force-pushed
the
entity-sub-type-check
branch
from
1d60ff8 to
cea30a4
Compare
XN137
force-pushed
the
entity-sub-type-check
branch
from
cea30a4 to
7d1695b
Compare
this is a follow-up to ac31963
XN137
force-pushed
the
entity-sub-type-check
branch
from
7d1695b to
561031c
Compare
HonahX
approved these changes
Sep 10, 2025
Contributor
HonahX
left a comment
HonahX
left a comment
There was a problem hiding this comment.
LGTM! Thanks for adding the check!
github-project-automation
bot
moved this from Ready to merge
to Done
in Basic Kanban Board
snazy
added a commit
to snazy/polaris
that referenced
this pull request
Nov 20, 2025
* Fix deprecation warnings in GcpCredentialsStorageIntegrationTest (apache#2544) * Fix deprecation warnings in GcpCredentialsStorageIntegrationTest Refactor the code to use an explicit InputStream Cf. FasterXML/jackson-core#803 * Add subtype-check to PolarisEntity subclass ctors (apache#2492) this is a follow-up to ac31963 * Inject PolarisAdminService into PolarisServiceImpl (apache#2533) `PolarisServiceImpl` already is a request-scoped bean. if we apply the same to `PolarisAdminService` we can simply inject it into `PolarisServiceImpl`. * Reduce getOrCreateMetaStoreManager callers (apache#2532) we can inject `PolarisMetaStoreManager` directly into request-scoped beans or build it only once in tests that operate in a single realm. * Update dependency mypy to >=1.18, <=1.18.1 (apache#2547) * Update dependency pyiceberg to v0.10.0 (apache#2549) Co-authored-by: Yong Zheng <yongzheng0809@gmail.com> * Minor fix for README.md (apache#2558) * Testing: Let runtime-service tests use Quarkus via `enforcedPlatform()` (apache#2545) This change ensures that the tests in runtime-service use the same Quarkus platform dependency versions as Polaris server does. * Update quay.io/keycloak/keycloak Docker tag to v26.3.4 (apache#2553) * Update dependency software.amazon.awssdk:bom to v2.33.9 (apache#2561) * NoSQL: remove unused type * Last merged commit a2f29cb * disable flaky test apache#2563 --------- Co-authored-by: Dmitri Bourlatchkov <dmitri.bourlatchkov@gmail.com> Co-authored-by: Christopher Lambert <xn137@gmx.de> Co-authored-by: Mend Renovate <bot@renovateapp.com> Co-authored-by: Yong Zheng <yongzheng0809@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a follow-up to ac31963