Fixing links (new PR for approved PR #136) #307
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaret-basden
requested review from
RussellSpitzer,
ashvina,
flyrain,
jackye1995,
jbonofre,
snazy,
takidau and
vvcephei
as code owners
collado-mike
approved these changes
Sep 18, 2024
Contributor
|
I think @eric-maynard's comment in #136 is still valid, #136 (comment) |
| <p>If you’re using a storage type other than S3, such as Azure, you’ll provide a different type of credential than a Role ARN. For more details on supported storage types, see the <a href="./entities.md#storage-type">docs</a>.</p> | ||
| <p>Additionally, if Polaris is running somewhere other than <code>localhost:8181</code>, you can specify the correct hostname and port by providing <code>--host</code> and <code>--port</code> flags. For the full set of options supported by the CLI, please refer to the <a href="./command-line-interface.md">docs</a>.</p> | ||
| <p>If you’re using a storage type other than S3, such as Azure, you’ll provide a different type of credential than a Role ARN. For more details on supported storage types, see the <a href="#storage-type">docs</a>.</p> | ||
| <p>Additionally, if Polaris is running somewhere other than <code>localhost:8181</code>, you can specify the correct hostname and port by providing <code>--host</code> and <code>--port</code> flags. For the full set of options supported by the CLI, please refer to the <a href="https://github.com/apache/polaris/blob/main/docs/command-line-interface.md">docs</a>.</p> |
Contributor
There was a problem hiding this comment.
If I am reading this correctly, clicking a link in a doc on the website will lead you to a doc on github? That feels bad
Contributor
There was a problem hiding this comment.
To add to it, it points to the main branch only, which breaks other branches.
https://github.com/apache/polaris/blob/main/docs/...
Contributor
There was a problem hiding this comment.
I'd recommend to move forward with a way to support a relative paths. We can play with building tools to support it.
flyrain
reviewed
Sep 28, 2024
| If you’re using a storage type other than S3, such as Azure, you’ll provide a different type of credential than a Role ARN. For more details on supported storage types, see the [docs](#storage-type). | ||
|
|
||
| Additionally, if Polaris is running somewhere other than `localhost:8181`, you can specify the correct hostname and port by providing `--host` and `--port` flags. For the full set of options supported by the CLI, please refer to the [docs](./command-line-interface.md). | ||
| Additionally, if Polaris is running somewhere other than `localhost:8181`, you can specify the correct hostname and port by providing `--host` and `--port` flags. For the full set of options supported by the CLI, please refer to the [docs](https://github.com/apache/polaris/blob/main/docs/command-line-interface.md). |
Contributor
There was a problem hiding this comment.
command-line-interface.md is in the same directory as this file. We don't need this change.
Contributor
|
Hi @jaret-basden , the new website is online now, can you double check how this PR applies to new docs framework? I assume some changes are not needed anymore, you can check details here, https://polaris.apache.org/in-dev/unreleased/quickstart/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Opening this PR to redo most of the changes in approved PR #136. PR #136 has gotten out of sync, so I'm opening this new PR instead of rebasing.
I didn't fix the docs link in docs/command-line-interface.md per jbonofre's comment in closed PR #231.
Fixes # (issue): N/A
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist:
Please delete options that are not relevant.