Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing typo in docs #328

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Fixing typo in docs #328

merged 2 commits into from
Oct 1, 2024

Conversation

mrcnc
Copy link
Contributor

@mrcnc mrcnc commented Sep 30, 2024 •
edited
Loading

Description

I believe there is a typo in the docs of the Polaris management service.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

Please delete options that are not relevant.

  • I have made corresponding changes to the documentation

flyrain
flyrain previously approved these changes Sep 30, 2024
View reviewed changes
eric-maynard
eric-maynard requested changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@eric-maynard eric-maynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This is the spec not the docs)

To regenerate docs, please run docs/build

Once that's done, this looks good to merge. Thanks for the fix, and good find!

eric-maynard
eric-maynard approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@eric-maynard eric-maynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@eric-maynard eric-maynard merged commit 3e434ca into apache:main Oct 1, 2024
3 checks passed
@mrcnc mrcnc deleted the fix-typo branch October 1, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-maynard eric-maynard eric-maynard approved these changes

@flyrain flyrain flyrain left review comments

@jbonofre jbonofre Awaiting requested review from jbonofre jbonofre is a code owner

@ashvina ashvina Awaiting requested review from ashvina ashvina is a code owner

@RussellSpitzer RussellSpitzer Awaiting requested review from RussellSpitzer RussellSpitzer is a code owner

@snazy snazy Awaiting requested review from snazy snazy is a code owner

@vvcephei vvcephei Awaiting requested review from vvcephei vvcephei is a code owner

@takidau takidau Awaiting requested review from takidau takidau is a code owner

@jackye1995 jackye1995 Awaiting requested review from jackye1995 jackye1995 is a code owner

@collado-mike collado-mike Awaiting requested review from collado-mike collado-mike is a code owner

@ebyhr ebyhr Awaiting requested review from ebyhr ebyhr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrcnc @flyrain @eric-maynard