Enable casting config values of most types #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew4699
requested review from
jbonofre,
ashvina,
RussellSpitzer,
snazy,
vvcephei,
takidau,
jackye1995,
flyrain,
eric-maynard,
collado-mike and
ebyhr
as code owners
eric-maynard
reviewed
Oct 4, 2024
polaris-core/src/main/java/org/apache/polaris/core/PolarisConfigurationStore.java
Outdated
Show resolved
Hide resolved
eric-maynard
reviewed
Oct 4, 2024
polaris-core/src/main/java/org/apache/polaris/core/PolarisConfigurationStore.java
Outdated
Show resolved
Hide resolved
eric-maynard
reviewed
Oct 4, 2024
| /** Unit test for the default behaviors of the PolarisConfigurationStore interface. */ | ||
| public class PolarisConfigurationStoreTest { | ||
| @Test | ||
| public void testConfigsCanBeCastedFromString() { |
There was a problem hiding this comment.
Can we also add a test for the negative case? e.g. a string is provided for an int
eric-maynard
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementations of PolarisConfigurationStore may return strings regardless of the config type. In particular, one place where this happens when specifying a ConfigOverride in a test.
Currently, the interface checks the expected type for booleans and Lists and casts them to the correct config type. Whether this is a pattern we should proliferate or not is up for debate, but this PR simply extends the existing logic to work for other types, and it adds tests to ensure the different castings work. Without this PR, the test fails.
Type of change
How Has This Been Tested?
Checklist: