Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #46

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Fix typo #46

merged 1 commit into from
Aug 1, 2024

Conversation

ebyhr
Copy link
Contributor

@ebyhr ebyhr commented Aug 1, 2024

Description

Fix typo

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

Please delete options that are not relevant.

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • If adding new functionality, I have discussed my implementation with the community using the linked GitHub issue
  • I have signed and submitted the ICLA and if needed, the CCLA. See Contributing for details.

@MonkeyCanCode
Copy link
Contributor

@ebyhr here is one more if you would like to add to the current PR (typo on entites):

Path: https://github.com/polaris-catalog/polaris/blob/main/docs/entities.md

original:

## Table

Polaris tables are entites that map to [Apache Iceberg tables](https://iceberg.apache.org/docs/nightly/configuration/).
...
## View

Polaris views are entites that map to [Apache Iceberg views](https://iceberg.apache.org/view-spec/).

new:

## Table

Polaris tables are entities that map to [Apache Iceberg tables](https://iceberg.apache.org/docs/nightly/configuration/).
...
## View

Polaris views are entities that map to [Apache Iceberg views](https://iceberg.apache.org/view-spec/).

emkornfield
emkornfield previously approved these changes Aug 1, 2024
@annafil annafil requested a review from a team August 1, 2024 17:59
@annafil annafil merged commit 1ace8f2 into apache:main Aug 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants