Fix ManifestFileCleanupTaskHandlerTest.testCleanupWithRetries #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test wrongly assumes that the ForkJoin Pool thread that will execute the async task will be a new one, and that it will inherit the thread locals from its parent, including CallContext. But that is not guaranteed.
adutra
requested review from
jbonofre,
ashvina,
RussellSpitzer,
snazy,
vvcephei,
takidau,
jackye1995,
flyrain,
eric-maynard,
collado-mike and
ebyhr
as code owners
flyrain
approved these changes
Dec 20, 2024
Comment on lines
+446
to
+447
| CompletableFuture<Void> future; | ||
| future = |
There was a problem hiding this comment.
minor suggestion: merge these two line together?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test wrongly assumes that the ForkJoin Pool thread that will execute the async task will be a new one, and that it will inherit the thread locals from its parent, including CallContext. But that is not guaranteed.