Convert FileIOIntegrationTest to a unit test #598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimas-b
requested review from
RussellSpitzer,
adutra,
ashvina,
collado-mike,
ebyhr,
eric-maynard,
flyrain,
jackye1995,
jbonofre,
snazy,
takidau and
vvcephei
as code owners
This makes exception handling tests more direct and more light-weight. Previously `FileIOIntegrationTest` used the full DW application stack just to exercise some custom test code in runtime. * Validate the basic fact of storage-level exception propagation to the REST API layer in `FileIOExceptionsTest`. * Validate relevant I/O exception message handling and status codes in `IcebergExceptionMapperTest`. * `IcebergExceptionMapper` is implicitly engages in runtime by the Web App framework based on its annotations.
dimas-b
force-pushed
the
file-io-unit-test
branch
from
2bf28ee to
98ad089
Compare
dimas-b
commented
Dec 31, 2024
| } | ||
|
|
||
| @Test | ||
| void testGetLengthExceptionSupplier() { |
Contributor
Author
There was a problem hiding this comment.
This test case has been dropped completely, but in reality it used to test just other test code 🤷
adutra
reviewed
Jan 2, 2025
.../service/src/test/java/org/apache/polaris/service/dropwizard/IcebergExceptionMapperTest.java
Show resolved
Hide resolved
adutra
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes exception handling tests more direct and more light-weight. Previously
FileIOIntegrationTestused the full DW application stack just to exercise some custom test code in runtime.Validate the basic fact of storage-level exception propagation to the REST API layer in
FileIOExceptionsTest.Validate relevant I/O exception message handling and status codes in
IcebergExceptionMapperTest.IcebergExceptionMapperis implicitly engaged in runtime by the Web App framework based on its annotations.