Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ASCII art to a classpath resource #72

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Move ASCII art to a classpath resource #72

merged 1 commit into from
Aug 2, 2024

Conversation

adutra
Copy link
Contributor

@adutra adutra commented Aug 2, 2024

Description

Moves ASCII art from Java code to a file on the classpath.

Type of change

Cosmetic

How Has This Been Tested?

Manually, since no test covers the ASCII art production.

Checklist:

Please delete options that are not relevant.

  • I have performed a self-review of my code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • I have signed and submitted the ICLA and if needed, the CCLA. See Contributing for details.

@adutra adutra requested a review from a team as a code owner August 2, 2024 10:18
@adutra adutra merged commit 913a54b into apache:main Aug 2, 2024
3 checks passed
@adutra adutra deleted the move-ascii-art-to-file branch August 2, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snazy snazy snazy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adutra @snazy