Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dns-java workarounds #863

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove dns-java workarounds #863

wants to merge 1 commit into from

Conversation

adutra
Copy link
Contributor

@adutra adutra commented Jan 23, 2025

The latest 3.6.2 version seems to fix the issue. I also tested with Postgres using the docker-compose files from #859 and had no issues.

@adutra
Copy link
Contributor Author

adutra commented Jan 23, 2025

Relates to #583

@snazy
Copy link
Member

snazy commented Jan 23, 2025

FYI the latest dnsjava versions come with META-INF/services/java.net.spi.InetAddressResolverProvider referencing their custom DNS resolver. But IIRC, that needs to be explicitly enabled via a system property.

@adutra
Copy link
Contributor Author

adutra commented Jan 23, 2025

FYI the latest dnsjava versions come with META-INF/services/java.net.spi.InetAddressResolverProvider referencing their custom DNS resolver. But IIRC, that needs to be explicitly enabled via a system property.

Indeed, that SPI impl was introduced in 3.6.0 and is enabled by a system property: org.dnsjava.spi.enable. I do not fully understand why the problem occurred, and why it disappeared. Maybe related to the switch to Quarkus and/or the fact that we don't produce shaded artifacts anymore.

@snazy
Copy link
Member

snazy commented Jan 23, 2025

projectnessie/nessie#9951 and projectnessie/nessie#9943 have some context. I think there was a problem with how dnsjava.jar was built (mr-jar) - and the Java runtime version - and likely, as you said, whether it's then run in an uber-jar.

@dimas-b
Copy link
Contributor

dimas-b commented Jan 23, 2025

@adutra : IIRC, dnsjava used to break EclipseLink with PostgreSQL. Did you have a change to test that? If bootstrap with PostgreSQL works, that's a good enough test.

Update: for extra certainty I think we ought to test on local machines :)

@dimas-b
Copy link
Contributor

dimas-b commented Jan 23, 2025

Java version may also be a factor.

@adutra
Copy link
Contributor Author

adutra commented Jan 24, 2025

@adutra : IIRC, dnsjava used to break EclipseLink with PostgreSQL. Did you have a change to test that? If bootstrap with PostgreSQL works, that's a good enough test.

Update: for extra certainty I think we ought to test on local machines :)

I tested with the new docker-compose files from #859 which include an example with EclispeLink and Postgres. Do you think that's enough?

Java version may also be a factor.

I only tested with Java 21.

@snazy
Copy link
Member

snazy commented Jan 24, 2025

I only tested with Java 21.

I guess that's fine then. The runtime requires Java 21.

Copy link
Contributor

@dimas-b dimas-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for tracking this down @adutra ! I guess we can always fix this again if it does not work in some env. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants