-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dns-java workarounds #863
base: main
Are you sure you want to change the base?
Conversation
Relates to #583 |
FYI the latest dnsjava versions come with |
Indeed, that SPI impl was introduced in 3.6.0 and is enabled by a system property: |
projectnessie/nessie#9951 and projectnessie/nessie#9943 have some context. I think there was a problem with how dnsjava.jar was built (mr-jar) - and the Java runtime version - and likely, as you said, whether it's then run in an uber-jar. |
@adutra : IIRC, Update: for extra certainty I think we ought to test on local machines :) |
Java version may also be a factor. |
I tested with the new docker-compose files from #859 which include an example with EclispeLink and Postgres. Do you think that's enough?
I only tested with Java 21. |
I guess that's fine then. The runtime requires Java 21. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thanks for tracking this down @adutra ! I guess we can always fix this again if it does not work in some env. :)
The latest 3.6.2 version seems to fix the issue. I also tested with Postgres using the docker-compose files from #859 and had no issues.