Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Expose get/setListenerName in the C API #369

Closed
roryschadler opened this issue Dec 8, 2023 · 2 comments · Fixed by #370
Closed

[Feature Request] Expose get/setListenerName in the C API #369

roryschadler opened this issue Dec 8, 2023 · 2 comments · Fixed by #370

Comments

@roryschadler
Copy link
Contributor

roryschadler commented Dec 8, 2023

https://github.com/apache/pulsar-client-cpp/blob/27cba3e7d154f97e01911cd5de2cc0d4eaf2ef50/lib/c/c_ClientConfiguration.cc doesn't seem to expose getListenerName and setListenerName from

/**
* Configure the listener name that the broker returns the corresponding `advertisedListener`.
*
* @param name the listener name
*/
ClientConfiguration& setListenerName(const std::string& listenerName);
/**
* @return the listener name for the broker
*/
const std::string& getListenerName() const;
That prevents the Node.js binding from exposing it (see related issue apache/pulsar-client-node#214), as it relies on the C API.

I'm not an expert, but at first glance this doesn't seem like a ton of work. I'd be willing to give it a shot.

@BewareMyPower
Copy link
Contributor

Yes. It should be easy. If you want to try this feature, you can take a look at the previous PRs that add new C APIs. https://github.com/apache/pulsar-client-cpp/commits/main/lib/c

@roryschadler
Copy link
Contributor Author

Thanks! Opened a PR: #370

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants