Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] [C API] Expose Get/Set Listener Name in C API #370

Merged

Conversation

roryschadler
Copy link
Contributor

Fixes #369

Motivation

The NodeJS client relies on the C API, which does not yet include the getListener and setListener methods. This means that using the NodeJS client, one is unable to choose which listener to create a client for.

Modifications

Exposed getListener and setListener via the C API.

Verifying this change

  • Make sure that the change passes the CI checks.
    • Added test for newly exposed methods

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@BewareMyPower
Copy link
Contributor

PR validation / Build the Wireshark dissector (macos-12) is very flaky due to the upstream (homebrew) issue. Let's ignore this test for now and merge it.

@BewareMyPower BewareMyPower merged commit 7087a8e into apache:main Dec 11, 2023
11 of 12 checks passed
@roryschadler
Copy link
Contributor Author

Thanks all for the quick review, and for looking into those checks! Do you know if there's an expected timeline for 3.5.0?

@roryschadler roryschadler deleted the expose-get-set-listener-in-c-api branch December 11, 2023 04:11
@BewareMyPower
Copy link
Contributor

I updated the timeline with 2023/01/19 just now.

@lluiscab
Copy link

lluiscab commented Feb 15, 2024

apache/pulsar-client-node#214 is currently being blocked due to these changes not being released. What's the expected timeline for a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Expose get/setListenerName in the C API
5 participants