Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add listenerName to client config #375

Merged

Conversation

roryschadler
Copy link
Contributor

@roryschadler roryschadler commented Apr 4, 2024

Fixes #214

Motivation

This library doesn't provide a way to pass a custom listener name to a Pulsar client, which is necessary if you have multiple advertised listeners and want to hit the non-default one: https://pulsar.apache.org/docs/next/concepts-multiple-advertised-listeners/

Modifications

After apache/pulsar-client-cpp#370, getListener and setListener are now exposed in the C API, and can be used by this library as well.

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

  • added listenerName to e2e tests where necessary (uses first advertisedListener by default)

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@roryschadler roryschadler force-pushed the allow-passing-listener-name-to-client-config branch from 846a95f to bc835df Compare April 4, 2024 22:03
@shibd
Copy link
Member

shibd commented Apr 5, 2024

@roryschadler hi, I'm doing release v1.11.0, Do you want to include it in v1.11.0?

@roryschadler
Copy link
Contributor Author

roryschadler commented Apr 5, 2024

@shibd yes, that would be great! Thanks @merlimat for the quick review. It looks like all the checks are green (except for the ARM64 linux_glibc check, as of now, it's still running all are green). If you're good to go with it, I'd love to include it!

@shibd shibd merged commit 81ab43d into apache:master Apr 6, 2024
12 checks passed
shibd pushed a commit that referenced this pull request Apr 7, 2024
* Allow passing listenerName to client config

* Add listener to test conf, e2e test

(cherry picked from commit 81ab43d)
@shibd shibd added this to the 1.11.0 milestone Apr 7, 2024
@roryschadler roryschadler deleted the allow-passing-listener-name-to-client-config branch April 18, 2024 15:02
@roryschadler roryschadler restored the allow-passing-listener-name-to-client-config branch April 18, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client configuration is missing the listenerName parameter
3 participants