Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] PIP 107: Introduce chunk message ID #148

Merged
merged 7 commits into from
Dec 20, 2022

Conversation

RobertIndie
Copy link
Member

Fixes #79

Motivation

This is the C++ implementation for apache/pulsar#12402

Modifications

  • Add ChunkMessageIdImpl
  • Return ChunkMessageId when the Producer produces the chunk message or when the consumer consumes the chunk message.
  • In cosumer.seek, use the first chunk message-id of the chunk message-id. This will solve the problem caused by seeking chunk messages. This is also the impact of this PIP on the original business logic.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@RobertIndie RobertIndie added this to the 3.2.0 milestone Dec 16, 2022
@RobertIndie RobertIndie self-assigned this Dec 16, 2022
@BewareMyPower BewareMyPower merged commit fa3ac76 into apache:main Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Support chunked message id
2 participants