Fix lazy partitioned producer might send duplicated messages #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes apache#341 ### Motivation When a lazy partitioned producer sends two messages, the flow is: 1. `start` is called to grab the connection via `grab()`. 2. Generate 0 as the sequence id of the 1st message. 3. Add the 1st message into the queuea. 4. The connection is established, `msgSequenceGenerator_` is reset from 1 to 0. 5. When sending the 2nd message, 0 is also generated as the sequence id. Then two messages have the same sequence id. ### Modifications For lazy partitioned producers, if the internal producer is not started, sending the message in the callback of its future. Add `ChunkDedupTest#testLazyPartitionedProducer` to verify it since only the `tests/chunkdedup/docker-compose.yml` enables the deduplication.
BewareMyPower
requested review from
merlimat,
RobertIndie,
Demogorgon314 and
shibd
shibd
approved these changes
Nov 11, 2023
BewareMyPower
added a commit
that referenced
this pull request
Nov 17, 2023
Fixes #341 ### Motivation When a lazy partitioned producer sends two messages, the flow is: 1. `start` is called to grab the connection via `grab()`. 2. Generate 0 as the sequence id of the 1st message. 3. Add the 1st message into the queuea. 4. The connection is established, `msgSequenceGenerator_` is reset from 1 to 0. 5. When sending the 2nd message, 0 is also generated as the sequence id. Then two messages have the same sequence id. ### Modifications For lazy partitioned producers, if the internal producer is not started, sending the message in the callback of its future. Add `ChunkDedupTest#testLazyPartitionedProducer` to verify it since only the `tests/chunkdedup/docker-compose.yml` enables the deduplication. (cherry picked from commit bb16f24)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #341
Motivation
When a lazy partitioned producer sends two messages, the flow is:
startis called to grab the connection viagrab().msgSequenceGenerator_is reset from 1 to 0.Then two messages have the same sequence id.
Modifications
For lazy partitioned producers, if the internal producer is not started, sending the message in the callback of its future.
Add
ChunkDedupTest#testLazyPartitionedProducerto verify it since only thetests/chunkdedup/docker-compose.ymlenables the deduplication.