Fix Protobuf symbols not found in libpulsarwithdeps.a when building on macOS #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
requested review from
merlimat,
RobertIndie,
Demogorgon314 and
shibd
BewareMyPower
force-pushed
the
bewaremypower/fix-macos-static-build
branch
from
5eefb7f
to
8925794
Compare
BewareMyPower
force-pushed
the
bewaremypower/fix-macos-static-build
branch
2 times, most recently
from
2524c55
to
fdd3069
Compare
…n macOS ### Motivation apache#290 brings a regression that on macOS, Protobuf is always found with CMake Config mode, which does not set the `Protobuf_LIBRARIES` variable so that the libpulsarwithdeps.a misses the symbols of Protobuf. ### Modifications When `LINK_STATIC` is ON, use CMake Module mode to find the Protobuf. Add `build-static-library.sh` to build libraries with static dependencies and verify these libraries in PR workflow. Upload the pre-built binaries in the build workflow.
BewareMyPower
force-pushed
the
bewaremypower/fix-macos-static-build
branch
from
fdd3069
to
a5dc8a6
Compare
|
I ran a workflow to generate macOS artifacts here: https://github.com/BewareMyPower/pulsar-client-cpp/actions/runs/6943109321 You can check https://github.com/apache/pulsar-client-cpp/wiki/Verify-the-candidate-release-in-your-local-env#macos-users for how to use it. These artifacts will be included in the next candidate release. |
shibd
approved these changes
Nov 21, 2023
BewareMyPower
added a commit
that referenced
this pull request
Nov 21, 2023
…n macOS (#354) ### Motivation #290 brings a regression that on macOS, Protobuf is always found with CMake Config mode, which does not set the `Protobuf_LIBRARIES` variable so that the libpulsarwithdeps.a misses the symbols of Protobuf. ### Modifications When `LINK_STATIC` is ON, use CMake Module mode to find the Protobuf. Add `build-static-library.sh` to build libraries with static dependencies and verify these libraries in PR workflow. Upload the pre-built binaries in the build workflow. (cherry picked from commit f75b39b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#290 brings a regression that on macOS, Protobuf is always found with CMake Config mode, which does not set the
Protobuf_LIBRARIESvariable so that the libpulsarwithdeps.a misses the symbols of Protobuf.Modifications
When
LINK_STATICis ON, use CMake Module mode to find the Protobuf.Add
build-static-library.shto build libraries with static dependencies and verify these libraries in PR workflow. Upload the pre-built binaries in the build workflow.