Fix wrong TimeUtils::currentTimeMillis() implementation #387
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
TimeUtils::currentTimeMillis()
is used to get the timestamp since 1970 buthigh_resolution_clock
does not necessarily represent the system clock. For example, given the following code:The outputs could be:
Modifications
Use
std::system_clock
forcurrentTimeMillis()
. AddBackoffTest.testCurrentTimeMillis
to verify the result is similar to 1000 times oftime(nullptr)
(the timestamp in seconds from the C API).