Use vcpkg to build macOS packages #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
force-pushed
the
bewaremypower/fix-macos-build
branch
from
3de8c36 to
42cd284
Compare
BewareMyPower
force-pushed
the
bewaremypower/fix-macos-build
branch
from
69fff36 to
b63fb20
Compare
This reverts commit af8fd74.
BewareMyPower
force-pushed
the
bewaremypower/fix-macos-build
branch
3 times, most recently
from
33313ed to
ff0a581
Compare
BewareMyPower
force-pushed
the
bewaremypower/fix-macos-build
branch
from
ff0a581 to
382c9d9
Compare
BewareMyPower
changed the title
RobertIndie
reviewed
Dec 23, 2024
|
@RobertIndie I've updated the approach with patching, PTAL again. In addition, I removed the macOS build workflow with homebrew dependencies because the latest Boost is no longer compatible with the code base, see https://github.com/apache/pulsar-client-cpp/actions/runs/12498761411/job/34872997202 |
RobertIndie
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #464
The manual build of 3rd party libraries are error-prone. It seems that on x86_64 platform
libsnappy.ais a universal binary that cannot be operated withar. This PR switches to vcpkg for a reliable build for dependencies.It should be noted that vcpkg enables IPv6 by default when building libcurl, which makes the
libcurl.arequire the dynamic linking to some macOS frameworks. e.g. you need to add-framework SystemConfiguration -framework CoreFoundationlink option, and even-framework CoreServicesoption for macOS 14 (see curl/curl#11893). This is not user friendly for the downstream libraries like pulsar-client-node.Therefore, this PR builds macOS libraries via patching vcpkg to disable the IPv6 feature of libcurl for macOS. The upstream does not accept this change, see microsoft/vcpkg#35834.
Two customized triplets files are added: