Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add OrderingKey related apis #401

Closed
freeznet opened this issue Nov 30, 2020 · 0 comments · Fixed by #427
Closed

add OrderingKey related apis #401

freeznet opened this issue Nov 30, 2020 · 0 comments · Fixed by #427
Assignees
@freeznet
Labels
area/producer triage/week-49

Comments

@freeznet
Copy link
Contributor

Is your feature request related to a problem? Please describe.
According to apache/pulsar#4079, orderingKey was introduced to let user set message order manually, currently pulsar-client-go do not have related apis exposed to user. We should add orderingKey related apis to ProducerMessage and Message.

Describe the solution you'd like

  • add OrderingKey to ProducerMessage
  • add OrderingKey() to Message interface
  • sync OrderingKey to SingleMessageMetadata

Additional context
Once this issue is resolved, new test with key batch builder should add as well. ref: #400
@freeznet freeznet mentioned this issue Nov 30, 2020
Merged
@sijie sijie mentioned this issue Nov 30, 2020
Closed
@freeznet freeznet mentioned this issue Dec 22, 2020
Merged
wolfstudy pushed a commit that referenced this issue Dec 23, 2020
@freeznet
[Issue #401] Add orderingKey apis (#427)
9b20cc0 
Fixes #401

### Motivation
According to apache/pulsar#4079, orderingKey was introduced to let user set message order manually, currently pulsar-client-go do not have related apis exposed to user. We should add orderingKey related apis to pulsar-client-go.

### Modifications

- add OrderingKey to ProducerMessage
- add OrderingKey() to Message interface
- sync OrderingKey to SingleMessageMetadata
- tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@freeznet freeznet

Labels
area/producer triage/week-49
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Issue #401] Add orderingKey apis freeznet/pulsar-client-go
2 participants
@sijie @freeznet