Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeyBasedBatchBuilder not work in perf code #475

Closed
jonyhy96 opened this issue Feb 25, 2021 · 0 comments · Fixed by #476
Closed

KeyBasedBatchBuilder not work in perf code #475

jonyhy96 opened this issue Feb 25, 2021 · 0 comments · Fixed by #476

Comments

@jonyhy96
Copy link
Contributor

Expected behavior

perf code will works well when batch builder set to KeyBasedBatchBuilder

Actual behavior

panic: multi batches container not support Flush(), please use FlushBatches() instead

Steps to reproduce

Set BatcherBuilderType to pulsar.KeyBasedBatchBuilder in perf code, run the perf with

$ perf -r 1000 my-topic

System configuration

Pulsar version: any
@jonyhy96 jonyhy96 mentioned this issue Feb 25, 2021
Merged
1 task
@sijie sijie mentioned this issue Feb 25, 2021
Closed
wolfstudy pushed a commit that referenced this issue Mar 5, 2021
@jonyhy96
fix: batch flush method (#476)
cd210a1 
Signed-off-by: jonyhy96 <hy352144278@gmail.com>

Fixes #475

### Motivation

Fix wrong batch flush method bug.

### Modifications

Check if batchBuilder is multi batches before flush.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: batch flush method
1 participant
@jonyhy96