Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Fix DLQ producer name conflicts when multiples consumers send messages to DLQ #1156

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

crossoverJie
Copy link
Member

Motivation

To keep consistent with the Java client.

Releted PR: apache/pulsar#21890

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Set DLQ producerName fmt.Sprintf("%s-%s-%s-DLQ", r.topicName, r.subscriptionName, r.consumerName)

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / GoDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@crossoverJie
Copy link
Member Author

@RobertIndie PTAL

Copy link
Contributor

@zzzming zzzming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we just found this issue. Thanks for fixing it.

@RobertIndie RobertIndie merged commit 4e13822 into apache:master Jan 15, 2024
6 checks passed
RobertIndie pushed a commit that referenced this pull request Jan 15, 2024
…essages to DLQ (#1156)

### Motivation

To keep consistent with the Java client.
Releted PR: apache/pulsar#21890

### Modifications

Set DLQ producerName `fmt.Sprintf("%s-%s-%s-DLQ", r.topicName, r.subscriptionName, r.consumerName)`

(cherry picked from commit 4e13822)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants