fix: failTimeoutMessages cannot delete outdated messages #1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. @RobertIndie @crossoverJie Could you review this pr? |
gunli
reviewed
Jul 19, 2024
RobertIndie
approved these changes
Jul 22, 2024
RobertIndie
pushed a commit
that referenced
this pull request
Jul 31, 2024
* fix: failTimeoutMessages cannot delete outdated messages * Fix slice pass (cherry picked from commit a42cc24)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1236
Motivation
When the producer reconnects to the broker, resending the pending messages, and changing the
sentAt, this will break thefailTimeoutMessagesfeature, which comparessentAtwith the current time to determine if the message has the timeout.Modifications
createdAttopendingItemstruct.sentAtandcreatedAtwhen sending the message, and updatesentAtwhen resending the message to the broker.Verifying this change
Use existing tests.