ci: validate multiple version builds and use golangci-lint-action #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodece
force-pushed
the
validate-multiple-version-builds
branch
2 times, most recently
from
07f82fd
to
a1c0974
Compare
nodece
changed the title
nodece
force-pushed
the
validate-multiple-version-builds
branch
from
0220fb8
to
0d3b709
Compare
tisonkun
approved these changes
Jul 14, 2024
tisonkun
reviewed
Jul 14, 2024
Comment on lines
+43
to
+45
| uses: golangci/golangci-lint-action@v6 | ||
| with: | ||
| version: v1.51.2 |
There was a problem hiding this comment.
Why this change? We still provide the Makefile target. This unaligned may silently cause CI logic and dev logic different ..
Both download binaries so that time consumption should be similiar.
There was a problem hiding this comment.
golangci/golangci-lint-action can report lint result to the ci summary.
When we update the golangci-lint, we must update the workflow and makefile files to keep same version.
RobertIndie
pushed a commit
that referenced
this pull request
Jul 31, 2024
) * ci: validate multiple version builds and use golangci-lint-actio * Fix lint (cherry picked from commit 2ff2c2c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Improve CI.
Modifications
go-version: [ '1.20', '1.21', '1.22' ]matrix.golangci/golangci-lint-action@v6, the lint result will be reported on the pr.