improve: use chan *message instead of chan []*message as queueCh #1283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodece
force-pushed
the
improve-dispatcher
branch
from
516d63b
to
c2e905c
Compare
nodece
changed the title
nodece
force-pushed
the
improve-dispatcher
branch
from
c2e905c
to
75ceb3b
Compare
RobertIndie
approved these changes
Oct 8, 2024
shibd
added a commit
to shibd/pulsar-client-go
that referenced
this pull request
Nov 26, 2024
This was referenced Nov 26, 2024
BewareMyPower
pushed a commit
that referenced
this pull request
Nov 26, 2024
### Motivation For the issue please refer to the PR description: #1310 Here have an analysis: #1310 (comment) ### Modifications - Rever #1283 - Add test from #1310 to cover `queueCh` never not full.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We currently use
chan []*messageas queueCh, and use the slice to stage the messages to send the message to the parent consumer, this will result in excessive use of memory.This PR optimizes potentially reducing overall memory overhead.
Modifications
chan *messageinstead ofchan []*message.