[Issue 1297][consumer] Fix DLQ producer name conflicts when there are same name consumers #1314
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1297
Master Issue: apache/pulsar#21589
Motivation
When multiple consumers with same name are using dlq policies at the same time, prompt will throw below exceptions:
ERRO[0069] Failed to create DLQ producer dlq-topic="persistent://<tenant>/<namespace>/<topic>-<subscription>-DLQ" error="server error: ProducerBusy: org.apache.pulsar.broker.service.BrokerServiceException$NamingException: Producer with name '-<subscription>-<consumerName>-DLQ' is already connected to topic"
Modifications
Add a random suffix in dlq producer name like:
opt.Name = fmt.Sprintf("%s-%s-%s-%s-DLQ", r.topicName, r.subscriptionName, r.consumerName, generateRandomName())
Verifying this change
This change is already covered by existing tests, such as
pulsar/consumer_test.go#TestDLQ(t *testing.T)
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation
I will create a followup issue for adding the documentation later.