[Issue 240] Add check for max message size #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. When creating a connection, try to get maxMessageSize from handshake response command. If it's not set, then use the default maxMessageSize value defined in the client side. 2. When sending a message, check whether the size of payload exceeds maxMessageSize. If so, return error immediately without adding this meesage into sending queue. 3. To implement these, I made some tiny modifications in Connection interface and added a field in its implementation struct.
wolfstudy
reviewed
May 26, 2020
|
@wolfstudy okay, I'll try to add some test cases for this change later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #240
Motivation
Issue #240: Add client-side check for max message size
Modifications
When creating a connection, try to get maxMessageSize from handshake
response command. If it's not set, then use the default maxMessageSize
value defined in the client side.
When sending a message, check whether the size of payload exceeds
maxMessageSize. If so, return error immediately without adding this
meesage into sending queue.
To implement these, I made some tiny modifications in Connection
interface and added a field in its implementation struct.