Read the clock fewer times during message routing #408
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we read the system clock twice for each event unless we
switched partitions early due to reaching
maxBatchingMessages
ormaxBatchingSize
.Now, we read the clock once every
maxBatchingMessages / 100
messages.This improves performance (especially for larger batch sizes) as the
router function is called for every message produced.
A bench test of the default router was added; results are below:
Signed-off-by: Daniel Ferstay dferstay@splunk.com
Motivation
The default_router reads the system clock twice for every message routed in the production code path. When testing at scale with larger batch sizes the amount of time spent reading the system clock during message routing shows up in pprof profiles.
Modifications
This change modifies the default router to read the system clock once for every
maxBatchingMessages / 100
messages routed.A bench test of the default router was added to verify that the change yields a speedup.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
Documentation