Fix unsubscribe blocked when consumer is closing or has closed #457
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For the present consumer,
Close()
andUnsubscribe()
handled by the same eventloop goroutine.The eventloop exited after
Close()
, then unsubscribe event wouldn't be selected and handled anymore, lead to block.example:
Unsubscribe()
blocked:Modifications
Check consumer state before send unsubscribe event, if consumer is closing or has closed, just logging it
Verifying this change