Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 444][fix] Use newError to build return error #471

Merged
merged 1 commit into from
Mar 5, 2021
Merged

[Issue 444][fix] Use newError to build return error #471

merged 1 commit into from
Mar 5, 2021

Conversation

jonyhy96
Copy link
Contributor

@jonyhy96 jonyhy96 commented Feb 22, 2021

Fixes #444

Motivation

For better error assertion in client side.

Modifications

Fix newError and use newError to build return error in most case.

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): no
  • The public API: no
  • The schema: no
  • The default values of configurations: no
  • The wire protocol: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? GoDocs

Signed-off-by: jonyhy96 <hy352144278@gmail.com>
@jonyhy96
Copy link
Contributor Author

/cc @freeznet

Copy link
Contributor

@freeznet freeznet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your work on this, LGTM.

Copy link
Member

@wolfstudy wolfstudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@wolfstudy wolfstudy merged commit 2e1f9c4 into apache:master Mar 5, 2021
@wolfstudy wolfstudy added this to the 0.5.0 milestone Mar 5, 2021
@jonyhy96 jonyhy96 deleted the fix-error-results branch March 5, 2021 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some error results are commented
3 participants