User-defined metric cardinality #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
reviewed
Aug 28, 2021
| type Metrics struct { | ||
| metricsLevel int |
There was a problem hiding this comment.
Would it make sense to define a 2nd enum for internal use instead of ints?
There was a problem hiding this comment.
It might, but that’s definitely a hack around some layout problems. But there probably aren’t any half-measures there, save an awkward new package, so I guess that’s a ticket for another day.
There was a problem hiding this comment.
One option could be to make the consts be strings instead of integers, and then have internal do a switch on these. Then at least the hard-coded values would have more meaning than inscrutable integer values. Like
type MetricsCardinality string
const (
MetricsCardinalityNone MetricsCardinality = `none`
MetricsCardinalityTenant MetricsCardinality = `tenant`
MetricsCardinalityNamespace MetricsCardinality = `namespace`
MetricsCardinalityTopic MetricsCardinality = `topic`
)
merlimat
approved these changes
Aug 28, 2021
wolfstudy
approved these changes
Oct 9, 2021
Signed-off-by: xiaolongran <xiaolongran@tencent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft
WIP, no test exercise yet, but passes docker-ci.sh tests. Feedback welcome.
I am a bit dissatisfied with the use of the const/iota enum in the public package and the integers in
internal,but it's necessary to avoid import cycles. Otherwise the enum needs to be moved out ofpulsarand placed into another package, or the enum needs to be mirrored ininternalFixes #500
Motivation
Allow selective metrics cardinality configuration
Modifications
Allow log cardinality level to be set to none, tenant, namespace or topic.