Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue 840][client] batchReceive support for consumer #849

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

labuladong
Copy link
Contributor

@labuladong labuladong commented Sep 19, 2022

Note: this pr is still a draft and waiting for #848 to be merged.

Master Issue: #840

Motivation

Add batchReceive method for consumers.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)

Documentation

  • Does this pull request introduces a new feature? yes
  • If yes, how is the feature documented? not documented
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@Gleiphir2769
Copy link
Contributor

Hi @labuladong , Does the batch index level ack will be supported in this PR?

Or this PR is only used to support batch receive and the batch index ack is in another plan?

@labuladong
Copy link
Contributor Author

Hi @Gleiphir2769, for now, this pr is just for the batch receive policy. No implementation of batch index level ack.

@frodopwns
Copy link

How is this working progressing? I too have need of batch receive functionality in Go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants