Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature support oauth2 for node client #190

Merged

Conversation

tuteng
Copy link
Member

@tuteng tuteng commented Jan 15, 2022

  • The cpp client already supports oauth2 authentication, and some users want to support this feature in the node js client as well, so enable it in the node js client

@tuteng tuteng self-assigned this Jan 15, 2022
@@ -1,9204 +1,8 @@
{
"name": "pulsar-client",
"version": "1.6.0-rc.0",
"lockfileVersion": 2,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems we removed a lot of code, what were these codes used for?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, revert this change

Copy link
Contributor

@gaoran10 gaoran10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@hassanzia32
Copy link

Is there a timeline for when the 1.6.0 version is scheduled to be released?

@tuteng tuteng added this to the 1.6.0 milestone Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants