fix: Compatible with Node 12.3.0 and higher versions. #378
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After #301, will use the Mozilla CA certificate provided by the node.js. And use the
fs.rmSync
API to generate a local ca when install.But the fs.rmSync was introduced in Node.js v14.14.0, so an error will occur when installing now.
Modifications
fs.existsSync and unlinkSync
instead offs.rmSync
.v12.3.0
, theREADME
andpackage.json
should be modified to indicate that it is only compatible with versions 12.3.0 and above.Verifying this change
Test on ubuntu-22.04
Use node.js v12.3.0 can work.
Documentation
doc-required
(Your PR needs to update docs and you will update later)
doc-not-needed
(Please explain why)
doc
(Your PR contains doc changes)
doc-complete
(Docs have been already added)