Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Compile glibc binaries using node:buster instead of centos7 #389

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

shibd
Copy link
Member

@shibd shibd commented Jul 1, 2024

Motivation

Compile glibc binaries using node:buster instead of centos7 for two reasons:

  1. Binaries compiled with centos7 may not be compatible with the node:buster (glibc) environment.
  2. Centos7 has reached its End of Life (EOL)."

Modifications

Use node:${NODE_VERSION}-buster to build glibc-type binaries.

Verifying this change

  1. Multi linux_glibc oss verify passed.

    - name: Test NAPI file in linux_glibc containers
    if: matrix.image == 'linux_glibc'
    run: |
    ./tests/load-test.sh node:16-buster ${{matrix.cpu.platform}}
    ./tests/load-test.sh node:16-bullseye ${{matrix.cpu.platform}}
    ./tests/load-test.sh node:19-buster ${{matrix.cpu.platform}}
    ./tests/load-test.sh node:19-bullseye ${{matrix.cpu.platform}}

  2. Self-release build passed and verified passed.
    https://github.com/shibd/pulsar-client-node/releases/tag/v1.11.0-fix.1
    You can install it by: npm install shibaodi-pulsar-client@1.11.0-fix.1

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@shibd shibd added this to the 1.12.0 milestone Jul 1, 2024
@shibd shibd self-assigned this Jul 1, 2024
@shibd shibd merged commit 54e6ba3 into apache:master Jul 2, 2024
12 checks passed
shibd added a commit that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants