Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support seek a MessageId from pulsar module #233

Merged

Conversation

BewareMyPower
Copy link
Contributor

Currently the seek method of Consumer or Reader can only accept the MessageId from the _pulsar module, which is the underlying C extension that should not be exposed. If a MessageId instance from the pulsar module is passed as the argument, this method will fail.

@BewareMyPower BewareMyPower added the bug Something isn't working label Dec 9, 2024
@BewareMyPower BewareMyPower added this to the 3.6.0 milestone Dec 9, 2024
@BewareMyPower BewareMyPower self-assigned this Dec 9, 2024
@BewareMyPower BewareMyPower marked this pull request as draft December 11, 2024 14:17
@BewareMyPower BewareMyPower force-pushed the bewaremypower/msg-id-compare branch from 4151fe9 to 71257dc Compare January 18, 2025 13:53
@BewareMyPower BewareMyPower marked this pull request as ready for review January 18, 2025 13:53
@BewareMyPower BewareMyPower force-pushed the bewaremypower/msg-id-compare branch from 71257dc to 44c4f4e Compare January 20, 2025 06:17
@BewareMyPower BewareMyPower merged commit 1c4ceb4 into apache:main Jan 20, 2025
11 checks passed
@BewareMyPower BewareMyPower deleted the bewaremypower/msg-id-compare branch January 20, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants