Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the minimum macOS version to 13 #239

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Set the minimum macOS version to 13 #239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac41342
Set the minimum macOS version to 13
BewareMyPower Jan 23, 2025
910e498
fix the upload-artifact plugin
BewareMyPower Jan 23, 2025
0972979
Use MACOSX_DEPLOYMENT_TARGET to specify mmacosx-version-min
BewareMyPower Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci-build-release-wheels.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ jobs:
/pulsar-client-python/pkg/test-wheel.sh

- name: Upload artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: wheel-${{matrix.image.name}}-py${{matrix.python.version}}-${{matrix.cpu.platform}}
path: wheelhouse/*.whl
Expand Down Expand Up @@ -115,7 +115,7 @@ jobs:
run: pkg/mac/build-mac-wheels.sh ${{matrix.py.version}} ${{matrix.py.version_long}}

- name: Upload artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: wheel-mac-py${{matrix.py.version}}
path: dist/*.whl
Expand Down Expand Up @@ -179,7 +179,7 @@ jobs:
python -c 'import pulsar; c = pulsar.Client("pulsar://localhost:6650"); c.close()'

- name: Upload artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: wheel-windows-py${{matrix.python.version}}
path: dist/*.whl
4 changes: 3 additions & 1 deletion pkg/mac/build-mac-wheels.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ fi
PYTHON_VERSION=$1
PYTHON_VERSION_LONG=$2

MACOSX_DEPLOYMENT_TARGET=13
# When building Python from source, it will read this environment variable to determine the minimum supported macOS version
export MACOSX_DEPLOYMENT_TARGET=13
pushd $CACHE_DIR

# We need to build OpenSSL from source to have universal2 binaries
Expand Down Expand Up @@ -99,6 +100,7 @@ if [ ! -f Python-${PYTHON_VERSION_LONG}/.done ]; then
tar xfz Python-${PYTHON_VERSION_LONG}.tgz

pushd Python-${PYTHON_VERSION_LONG}
export CFLAGS="-fPIC -O3"
./configure --prefix=$PREFIX --enable-shared --enable-universalsdk --with-universal-archs=universal2 --with-openssl=$PREFIX
make -j16
make install
Expand Down
Loading