Skip to content

Commit

Permalink
Fail the chart-testing job if linting fails (#429)
Browse files Browse the repository at this point in the history
  • Loading branch information
lhotari authored Jan 15, 2024
1 parent 8061a8b commit 62569f4
Showing 1 changed file with 1 addition and 12 deletions.
13 changes: 1 addition & 12 deletions .github/workflows/pulsar-helm-chart-ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,6 @@ jobs:
runs-on: ubuntu-22.04
timeout-minutes: 45
if: ${{ needs.preconditions.outputs.docs_only != 'true' }}
outputs:
no_chart_changes: ${{ steps.ct-lint.outputs.no_chart_changes }}
steps:
- name: checkout
uses: actions/checkout@v4
Expand Down Expand Up @@ -127,16 +125,7 @@ jobs:
run: |
ct lint --check-version-increment=false \
--validate-maintainers=false \
--target-branch ${{ github.event.repository.default_branch }} \
| tee /tmp/ct-lint.log || {
if grep -q "No chart changes detected." /tmp/ct-lint.log; then
echo no_chart_changes=true >> $GITHUB_OUTPUT
exit 0
else
echo no_chart_changes=false >> $GITHUB_OUTPUT
exit 1
fi
}
--target-branch ${{ github.event.repository.default_branch }}
- name: Wait for ssh connection when build fails
# ssh access is enabled for builds in own forks
Expand Down

0 comments on commit 62569f4

Please sign in to comment.