Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource specs for Init Containers #428

Merged
merged 6 commits into from
Jan 15, 2024
Merged

Resource specs for Init Containers #428

merged 6 commits into from
Jan 15, 2024

Conversation

Mortom123
Copy link
Contributor

@Mortom123 Mortom123 commented Jan 15, 2024

Implements #425

Motivation

As described in the FR some cluster providers are a little bit more "strict" regarding their deployed containers and the resources they are allowed to use. This patch introduces resources to all init containers together with a corresponding section in values.yaml

Modifications

values.yaml now has a new section initContainer_resources where each init container type is listed by name and describes the resources it is allowed to use.
I also addedd a blank resources section to pulsar_metadata because the currently existing template uses this attribute, however there was no sign of it in values.yaml which is unintuitive.

Verifying this change

  • Make sure that the change passes the CI checks.
    (I don't know how, but lemme know how so I can run the checks)

Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please increase the default memory limits

charts/pulsar/values.yaml Outdated Show resolved Hide resolved
charts/pulsar/values.yaml Outdated Show resolved Hide resolved
@lhotari lhotari merged commit 04b8cce into apache:master Jan 15, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants