Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use TLS from function instances to brokers by default #435

Merged

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Jan 17, 2024

Motivation

  • CI is currently broken after enabling Pulsar Function testing in all configuration with Test Pulsar Functions in CI #434
  • When TLS is enabled Function instances cannot communicate to the broker since Function instances don't currently have the custom TLS CA cert available.
  • When the function worker runs on the broker, the configuration PF_tlsAllowInsecureConnection: "true" has no impact and it's not possible to configure tlsAllowInsecureConnection=true only for the function instance. The function worker uses the broker configuration for the tlsAllowInsecureConnection setting and changing that would have a larger impact.

Modifications

  • Add new configuration tls.function_instance.enabled that defaults to false. This controls whether TLS is used from function instances to the broker.

Verifying this change

  • Make sure that the change passes the CI checks.

- Function instances don't currently have the TLS CA cert available
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants