-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default configuration for Pulsar Grafana dashboards #439
Conversation
@Mortom123 @frankjkelly Do you have a chance to review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed a few small typos / formatting issues
Thanks for the review @frankjkelly . I pushed changes to address your comments. PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
When deployed this way it is possible for a Grafana Admin to delete and redeploy any dashboard they wish? I ask because the StreamNative Pulsar Grafana Dicker image does a very strange deployment and build into the Grafana provisioning directories. |
There is no StreamNative Pulsar Grafana Docker image in play. Grafana's Helm chart is used under the covers and that has multiple ways to configure the Grafana dashboards. Documentation is at https://github.com/grafana/helm-charts/blob/main/charts/grafana/README.md#import-dashboards . |
…shboard that has been replaced - the "extra" key has been deprecated a long time ago - the dashboard is outdated and there's a replacement with kube-prometheus-stack and apache#439
Motivation
Using Prometheus and Grafana in the Pulsar Helm chart isn't very useful without Pulsar dashboards.
Modifications
Add default configuration for Pulsar Grafana dashboards. The Grafana dashboards are referenced by URL from the ASL 2.0 licenced repo https://github.com/streamnative/apache-pulsar-grafana-dashboard which contains maintained Pulsar Grafana dashboards.
The changes in this PR will populate Grafana with the Pulsar dashboards:
Verifying this change