Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default configuration for Pulsar Grafana dashboards #439

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Jan 23, 2024

Motivation

Using Prometheus and Grafana in the Pulsar Helm chart isn't very useful without Pulsar dashboards.

Modifications

Add default configuration for Pulsar Grafana dashboards. The Grafana dashboards are referenced by URL from the ASL 2.0 licenced repo https://github.com/streamnative/apache-pulsar-grafana-dashboard which contains maintained Pulsar Grafana dashboards.

The changes in this PR will populate Grafana with the Pulsar dashboards:
image

Verifying this change

  • Make sure that the change passes the CI checks.

@lhotari lhotari requested a review from tisonkun January 23, 2024 10:07
@lhotari
Copy link
Member Author

lhotari commented Jan 24, 2024

@Mortom123 @frankjkelly Do you have a chance to review this PR?

Copy link
Contributor

@frankjkelly frankjkelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed a few small typos / formatting issues

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@lhotari
Copy link
Member Author

lhotari commented Jan 24, 2024

Noticed a few small typos / formatting issues

Thanks for the review @frankjkelly . I pushed changes to address your comments. PTAL

Copy link
Contributor

@frankjkelly frankjkelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhotari lhotari merged commit d486e4a into apache:master Jan 24, 2024
27 checks passed
@dave2wave
Copy link
Member

dave2wave commented Jan 24, 2024

When deployed this way it is possible for a Grafana Admin to delete and redeploy any dashboard they wish? I ask because the StreamNative Pulsar Grafana Dicker image does a very strange deployment and build into the Grafana provisioning directories.

@lhotari
Copy link
Member Author

lhotari commented Jan 24, 2024

When deployed this way it is possible for a Grafana Admin to delete and redeploy any dashboard they wish? I ask because the StreamNative Pulsar Grafana Dicker image does a very strange deployment and build into the Grafana provisioning directories.

There is no StreamNative Pulsar Grafana Docker image in play. Grafana's Helm chart is used under the covers and that has multiple ways to configure the Grafana dashboards. Documentation is at https://github.com/grafana/helm-charts/blob/main/charts/grafana/README.md#import-dashboards .

lhotari added a commit to lhotari/pulsar-helm-chart that referenced this pull request Feb 21, 2024
…shboard that has been replaced

- the "extra" key has been deprecated a long time ago
- the dashboard is outdated and there's a replacement with kube-prometheus-stack and apache#439
lhotari added a commit that referenced this pull request Feb 21, 2024
…shboard that has been replaced (#461)

- the "extra" key has been deprecated a long time ago
- the dashboard is outdated and there's a replacement with kube-prometheus-stack and #439
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants