Add validation using kubeconform #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
force-pushed
the
lh-add-kubeconform-check-to-detect-invalid-keys
branch
3 times, most recently
from
f9c5911 to
0cd0241
Compare
lhotari
force-pushed
the
lh-add-kubeconform-check-to-detect-invalid-keys
branch
from
0cd0241 to
8f4e30f
Compare
|
@frankjkelly @Mortom123 Please review |
|
LGTM. Wonder what PR you mean... :D |
@Mortom123 this particular invalid indentation: #448 (comment) . It didn't get caught by validation. After adding |
frankjkelly
reviewed
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
helm lintdoesn't validate extra keys in the Kubernetes objects which could be a sign of typos or invalid indentation.kubeconformprovides a proper solution for that.kubeconformvalidation will catch helm installunknown fieldwarnings such as this:this happened in a recent PR when the indentation was incorrect.
Modifications
Verifying this change