Add support for admin port on ZooKeeper #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good point @lhotari, there is some security implications. Especially for existing clusters, where they might not be expecting the admin port being exposed. I'll update the PR to make the field optional, and removed by default. |
liamgib
commented
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #549
Motivation
We need to be able to access the ZooKeeper admin endpoint to perform automated snapshots to an external system.
Modifications
I have added the admin port to the list of Zookeeper ports, and made the relevant changes on the zookeeper-service.yaml & zookeeper-statefulset.yaml to use the admin port.
Verifying this change