Fix Oxia config so that it includes a list of all pods in the statefulset #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
force-pushed
the
lh-fix-oxia-config-server-pod-names
branch
from
7fa2fbf to
097eb17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #551
Motivation
There's an issue in the current Oxia configuration in Apache Pulsar Helm chart described in #551
Modifications
The config.yaml was invalid. In the original Oxia Helm chart, all pods of the statefulset are listed:
https://github.com/streamnative/oxia/blob/79fea6ac5a5ba61572505149a7024a46bb936ded/deploy/charts/oxia-cluster/templates/coordinator-configmap.yaml#L29-L32
A subtle mistake was made when this template was added to the Apache Pulsar Helm chart.
This PR adds similar logic to the configuration. The template logic contains variable names that make it easy to follow the logic.
Verifying this change