feat(tls): support ca type issuer and v1alpha* version cert-manager api #561
+169
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ericsyh <ericshenyuhao@outlook.com>
Signed-off-by: ericsyh <ericshenyuhao@outlook.com>
Signed-off-by: ericsyh <ericshenyuhao@outlook.com>
ericsyh
changed the title
lhotari
reviewed
Dec 13, 2024
Comment on lines
-51
to
-52
| - "*.{{ template "pulsar.fullname" . }}-{{ .Values.proxy.component }}.{{ template "pulsar.namespace" . }}.svc.{{ .Values.clusterDomain }}" | ||
| - "{{ template "pulsar.fullname" . }}-{{ .Values.proxy.component }}" |
There was a problem hiding this comment.
Is this removal a breaking change? Does this require release note instructions users that upgrade? Would it be possible to retain compatibility?
There was a problem hiding this comment.
Nope, it's not a breaking change cause i just move the position to make the format of proxy certificate dnsNames and broker certificate dnsNames to be consistent. It doesn't change the logic and technical this change is optional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Motivation
The current chart only supports enable tls with self-signed issuer which is not possible for production users. This PR supports ca type issuser which allows users to bound a root certificate (in
Secret) to issue required tls certificates for pulsar components.Modifications
certs.typeand add thecerts.issuers.ca.secretNamefield for the root certificate reference.Verifying this change